jasperjiaguo commented on code in PR #10636: URL: https://github.com/apache/pinot/pull/10636#discussion_r1184448926
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/ParentArgMinMaxAggregationFunction.java: ########## @@ -0,0 +1,382 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation.function; + +import com.google.common.base.Preconditions; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.context.ExpressionContext; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.core.common.BlockValSet; +import org.apache.pinot.core.query.aggregation.AggregationResultHolder; +import org.apache.pinot.core.query.aggregation.ObjectAggregationResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.GroupByResultHolder; +import org.apache.pinot.core.query.aggregation.groupby.ObjectGroupByResultHolder; +import org.apache.pinot.core.query.aggregation.utils.argminmax.ArgMinMaxObject; +import org.apache.pinot.core.query.aggregation.utils.argminmax.ArgMinMaxWrapperValSet; +import org.apache.pinot.segment.spi.AggregationFunctionType; + + +public class ParentArgMinMaxAggregationFunction extends ParentAggregationFunction<ArgMinMaxObject, ArgMinMaxObject> { + + // list of columns that we do min/max on + private final List<ExpressionContext> _measuringColumns; + // list of columns that we project based on the min/max value + private final List<ExpressionContext> _projectionColumns; + // true if we are doing argmax, false if we are doing argmin + private final boolean _isMax; + // the id of the function, this is to associate the result of the parent aggregation function with the + // child aggregation functions having the same type(argmin/argmax) and measuring columns + private final ExpressionContext _functionIdContext; + private final ExpressionContext _numMeasuringColumnContext; + // number of columns that we do min/max on + private final int _numMeasuringColumns; + // number of columns that we project based on the min/max value + private final int _numProjectionColumns; + + // The following variable need to be initialized + + // The wrapper classes for the block value sets + private final ThreadLocal<List<ArgMinMaxWrapperValSet>> _argMinMaxWrapperMeasuringColumnSets = + ThreadLocal.withInitial(ArrayList::new); + private final ThreadLocal<List<ArgMinMaxWrapperValSet>> _argMinMaxWrapperProjectionColumnSets = + ThreadLocal.withInitial(ArrayList::new); + // The schema for the measuring columns and projection columns + private final ThreadLocal<DataSchema> _measuringColumnSchema = new ThreadLocal<>(); + private final ThreadLocal<DataSchema> _projectionColumnSchema = new ThreadLocal<>(); + // If the schemas are initialized + private final ThreadLocal<Boolean> _schemaInitiated = ThreadLocal.withInitial(() -> false); + + public ParentArgMinMaxAggregationFunction(List<ExpressionContext> arguments, boolean isMax) { + + super(arguments); + _isMax = isMax; + _functionIdContext = arguments.get(0); + + _numMeasuringColumnContext = arguments.get(1); + _numMeasuringColumns = _numMeasuringColumnContext.getLiteral().getIntValue(); + + _measuringColumns = arguments.subList(2, 2 + _numMeasuringColumns); + _projectionColumns = arguments.subList(2 + _numMeasuringColumns, arguments.size()); + _numProjectionColumns = _projectionColumns.size(); + } + + @Override + public AggregationFunctionType getType() { + return _isMax ? AggregationFunctionType.ARGMAX : AggregationFunctionType.ARGMIN; + } + + @Override + public List<ExpressionContext> getInputExpressions() { + ArrayList<ExpressionContext> expressionContexts = new ArrayList<>(); + expressionContexts.add(_functionIdContext); + expressionContexts.add(_numMeasuringColumnContext); + expressionContexts.addAll(_measuringColumns); + expressionContexts.addAll(_projectionColumns); + return expressionContexts; + } + + @Override + public AggregationResultHolder createAggregationResultHolder() { + return new ObjectAggregationResultHolder(); + } + + @Override + public GroupByResultHolder createGroupByResultHolder(int initialCapacity, int maxCapacity) { + return new ObjectGroupByResultHolder(initialCapacity, maxCapacity); + } + + @SuppressWarnings("LoopStatementThatDoesntLoop") + @Override + public void aggregate(int length, AggregationResultHolder aggregationResultHolder, + Map<ExpressionContext, BlockValSet> blockValSetMap) { + + ArgMinMaxObject argMinMaxObject = aggregationResultHolder.getResult(); + + if (argMinMaxObject == null) { + initializeWithNewDataBlocks(blockValSetMap); + argMinMaxObject = new ArgMinMaxObject(_measuringColumnSchema.get(), _projectionColumnSchema.get()); + } + + List<Integer> rowIds = new ArrayList<>(); + for (int i = 0; i < length; i++) { + int compareResult = argMinMaxObject.compareAndSetKey(_argMinMaxWrapperMeasuringColumnSets.get(), i, _isMax); + if (compareResult == 0) { + // same key, add the rowId to the list + rowIds.add(i); + } else if (compareResult > 0) { + // new key is set, clear the list and add the new rowId + rowIds.clear(); + rowIds.add(i); + } + } + + // for all the rows that are associated with the extremum key, add the projection columns + for (Integer rowId : rowIds) { + argMinMaxObject.addVal(_argMinMaxWrapperProjectionColumnSets.get(), rowId); + } + + aggregationResultHolder.setValue(argMinMaxObject); + } + + // this method is called to initialize the schemas if they are not initialized + // and to set the new block value sets for the wrapper classes + private void initializeWithNewDataBlocks(Map<ExpressionContext, BlockValSet> blockValSetMap) { Review Comment: refactored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
