jasperjiaguo commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1184375266
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/QueryRewriterFactory.java:
##########
@@ -33,7 +33,7 @@ private QueryRewriterFactory() {
private static final Logger LOGGER =
LoggerFactory.getLogger(QueryRewriterFactory.class);
- static final List<String> DEFAULT_QUERY_REWRITERS_CLASS_NAMES =
+ public static final List<String> DEFAULT_QUERY_REWRITERS_CLASS_NAMES =
Review Comment:
Oh this is made visible also for us to conveniently configure in our config
files. Intentionally left ArgMinMaxRewriter out because we don't want to add
name check overhead to default codepath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
