gortiz commented on code in PR #10687:
URL: https://github.com/apache/pinot/pull/10687#discussion_r1183366016
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -637,23 +595,23 @@ private void addNewRow(int docId, GenericRow row) {
// Update numValues info
indexContainer._valuesInfo.updateSVNumValues();
- MutableForwardIndex forwardIndex = indexContainer._forwardIndex;
+ MutableIndex forwardIndex =
indexContainer._mutableIndexes.get(StandardIndexes.forward());
FieldSpec fieldSpec = indexContainer._fieldSpec;
DataType dataType = fieldSpec.getDataType();
value =
indexContainer._valueAggregator.getInitialAggregatedValue(value);
switch (dataType.getStoredType()) {
Review Comment:
That is what I though (see
https://github.com/apache/pinot/pull/10687/commits/6d6b08c6d6e156af597917a42e72ce493813d7ae),
but it is not a correct reasoning.
The value received by
`indexContainer._valueAggregator.getInitialAggregatedValue(value)` has to be a
Number, but it doesn't has to be the specific Number implementation the index
is expecting. For example, the column may be an int and the aggregation return
a double. I don't know if the transformation was correct (we may lose
information in the transformation), but it was what we were doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
