walterddr commented on code in PR #10692:
URL: https://github.com/apache/pinot/pull/10692#discussion_r1183211782
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -199,7 +199,7 @@ public static List<String>
extractTableNamesFromNode(SqlNode sqlNode) {
}
@VisibleForTesting
- static SqlNodeAndOptions extractSqlNodeAndOptions(String sql, SqlNodeList
sqlNodeList) {
+ public static SqlNodeAndOptions extractSqlNodeAndOptions(String sql,
SqlNodeList sqlNodeList) {
Review Comment:
based on a coarse search Connection class uses
`CalciteSqlParser.compileToSqlNodeAndOptions` and
`CalciteSqlParser.extractTableNamesFromNode`, not this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
