jtao15 commented on code in PR #10679:
URL: https://github.com/apache/pinot/pull/10679#discussion_r1183084142
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3723,13 +3764,26 @@ private boolean writeLineageEntryWithTightLoop(String
tableNameWithType, String
if (!currentLineageEntry.equals(lineageEntryToMatch)) {
String errorMsg = String.format(
"Aborting the to update lineage entry since we find that the entry
has been modified for table %s, "
- + "entry id: %s", tableNameWithType, lineageEntryId);
+ + "entry id: %s", tableConfig, lineageEntryId);
LOGGER.error(errorMsg);
throw new RuntimeException(errorMsg);
}
// Update lineage entry
segmentLineageToUpdate.updateLineageEntry(lineageEntryId,
lineageEntryToUpdate);
+ switch (replaceSegmentType) {
+ case START:
Review Comment:
We are not using `writeLineageEntryWithTightLoop()` for startReplacement api
currently, but I think it's fine to have it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
