walterddr commented on code in PR #10685:
URL: https://github.com/apache/pinot/pull/10685#discussion_r1177138148


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/ResourceBasedQueriesTest.java:
##########
@@ -375,9 +375,13 @@ private static Object[][] 
testResourceQueryTestCaseProviderWithMetadata()
               : replaceTableName(testCaseName, queryCase._sql);
 
           int segmentCount = 0;
-          for (String tableName : testCaseEntry.getValue()._tables.keySet()) {
-            segmentCount +=
-                _tableToSegmentMap.getOrDefault(testCaseName + "_" + tableName 
+ "_OFFLINE", new HashSet<>()).size();
+          if (queryCase._expectedNumSegments != null) {

Review Comment:
   what is this assert specifically doing? is it to test the segment level 
pruner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to