[GitHub] [pinot] saurabhd336 commented on a diff in pull request #10655: API to expose the contract/rules imposed by pinot on tableConfig

[via GitHub]

saurabhd336 commented on code in PR #10655:
URL: https://github.com/apache/pinot/pull/10655#discussion_r1173620687


##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -563,4 +592,30 @@ public boolean isBackwardCompatibleWith(FieldSpec 
oldFieldSpec) {
             && EqualityUtils.isEqual(_dataType, oldFieldSpec._dataType)
             && EqualityUtils.isEqual(_isSingleValueField, 
oldFieldSpec._isSingleValueField);
   }
+
+  public static class FieldSpecMetadata {
+    public Map<FieldType, FieldTypeMetadata> _fieldTypes = new HashMap<>();
+
+    void put(FieldType type, FieldTypeMetadata metadata) {
+      _fieldTypes.put(type, metadata);
+    }
+  }
+
+  public static class FieldTypeMetadata {
+    public List<DataTypeMetadata> _allowedDataTypes = new ArrayList<>();
+
+    void add(DataTypeMetadata metadata) {
+      _allowedDataTypes.add(metadata);
+    }
+  }
+
+  public static class DataTypeMetadata {
+    public FieldSpec.DataType _name;

Review Comment:
   DataType has a bunch of other useful properties that can be part of the 
response. 
   
   ```
   
       private final DataType _storedType;
       private final int _size;
       private final boolean _sortable;
       private final boolean _numeric;
   
   
   Think we should include all that in the API result. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org