shounakmk219 commented on code in PR #10623:
URL: https://github.com/apache/pinot/pull/10623#discussion_r1172532306
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -159,4 +159,74 @@ public TimestampConfig getTimestampConfig() {
public Map<String, String> getProperties() {
return _properties;
}
+
+ public static class Builder {
+ private String _name;
+ private EncodingType _encodingType;
+ private List<IndexType> _indexTypes;
+ private JsonNode _indexes;
+ private CompressionCodec _compressionCodec;
+ private Map<String, String> _properties;
+ private TimestampConfig _timestampConfig;
+ private JsonNode _tierOverwrites;
+
+ public Builder() {
+ }
+
+ public Builder(FieldConfig other) {
Review Comment:
fixed it
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/AbstractIndexType.java:
##########
@@ -62,6 +71,39 @@ public IndexReaderFactory<IR> getReaderFactory() {
return _readerFactory;
}
+ public void convertToNewFormat(TableConfig tableConfig, Schema schema) {
+ Map<String, C> deserialize = getConfig(tableConfig, schema);
+ for (Map.Entry<String, C> entry : deserialize.entrySet()) {
+ boolean fieldConfigFound = false;
+ List<FieldConfig> fieldConfigList = tableConfig.getFieldConfigList() ==
null
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
