snleee commented on code in PR #10645:
URL: https://github.com/apache/pinot/pull/10645#discussion_r1171576047
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/BaseSegmentPushJobRunner.java:
##########
@@ -50,12 +50,19 @@ public abstract class BaseSegmentPushJobRunner implements
IngestionJobRunner {
/**
* Initialize BaseSegmentPushJobRunner with SegmentGenerationJobSpec
- * Checks for required parameters in the spec and enablement of consistent
data push.
*/
@Override
public void init(SegmentGenerationJobSpec spec) {
+ init(spec, true);
+ }
+
+ /**
+ * Initialize BaseSegmentPushJobRunner with SegmentGenerationJobSpec
+ * Checks for required parameters in the spec and enablement of consistent
data push.
+ */
+ public void init(SegmentGenerationJobSpec spec, boolean checkPushJobSpec) {
Review Comment:
instead of adding `checkPushJobSpec` boolean flag, let's keep the
`BaseSegmentPushJobRunner` as it is and override init() function within
`SegmentTarPushJobRunner` with the old logic. Let's double check about
`tableSpec, tableConfigURI` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
