Jackie-Jiang commented on code in PR #10593:
URL: https://github.com/apache/pinot/pull/10593#discussion_r1165869470
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##########
@@ -450,20 +451,26 @@ private void deleteSchemaInternal(String schemaName) {
}
// If the schema is associated with a table, we should not delete it.
- List<String> tableNames =
_pinotHelixResourceManager.getAllRealtimeTables();
- for (String tableName : tableNames) {
- TableConfig config =
_pinotHelixResourceManager.getRealtimeTableConfig(tableName);
- String tableSchema = config.getValidationConfig().getSchemaName();
-
- if (schemaName.equals(tableSchema)) {
+ // TODO: Check OFFLINE tables as well
Review Comment:
The main concern is that this is behavior change, and out of the scope of
this PR. We can address this separately if desired, but need to explicitly call
out this behavior change. Thus left a TODO so that people aware of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
