gortiz opened a new pull request, #10585:
URL: https://github.com/apache/pinot/pull/10585

   This PR changes how IndexConfig are enabled/disabled. Instead of using 
`enabled`, we will use `disabled`.
   
   We discussed about this change in https://github.com/apache/pinot/pull/10584.
   
   This changes breaks compatibility. Specifically if someone used `enabled: 
false` to disable an index, this PR will ignore that configuration, as shown in 
the following table:
   
   | when enabled was  | prev this PR  | after this PR  | if we use disabled   |
   |---|---|---|---|
   | not defined  |  sometimes disables the index | enables the index  | 
enables the index |
   | null  | sometimes disables the index  | enables the index  | enables the 
index  |
   | true  | enables the index  | enables the index  | enables the index  |
   | false  | disables the index  | disables the index  | **enables the index** 
 |
   
   We assume that given that this new way to configure indexes was merged less 
than three weeks ago and no release was made, customer won't be actually using 
`enabled: false`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to