xiangfu0 commented on code in PR #10559:
URL: https://github.com/apache/pinot/pull/10559#discussion_r1159263248


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -181,6 +182,9 @@ protected void compareRowEquals(List<Object[]> resultRows, 
List<Object[]> expect
         }
         return Double.compare(ld, rd);
       } else if (l instanceof String) {
+        if (r instanceof byte[]) {

Review Comment:
   postgres give hex value, but with with a prefix: `\x`, e.g. 
`\x4A6F686E20446F65`, in my opinion, v1 response hex string is actually pretty 
good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to