snleee commented on code in PR #10542:
URL: https://github.com/apache/pinot/pull/10542#discussion_r1157872025
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
Review Comment:
Can you add the javadoc comment on what's the key and what's the value for
the header map?
##########
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##########
@@ -150,6 +151,10 @@ private void init()
_iterator = _parser.iterator();
}
+ public Map<String, Integer> getCSVHeaderMap() {
+ return _parser.getHeaderMap();
Review Comment:
what happens to the record reader / headermap
if there's no header present? we can cover this in the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
