gortiz commented on code in PR #10221: URL: https://github.com/apache/pinot/pull/10221#discussion_r1155679349
########## pinot-controller/pom.xml: ########## @@ -33,7 +33,7 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/..</pinot.root> - <npm.script>build</npm.script> + <npm.script>build-ci</npm.script> Review Comment: TBH that was the intention. The idea is that unless you want to build a production bundle, you should build the dev version. I don't think we need to rollback this, but what we can do is to run `npm build` when profile `bin-dist` is enabled, as that is the _maven way_ to say that we want to have a production bundle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
