saurabhd336 commented on code in PR #10370:
URL: https://github.com/apache/pinot/pull/10370#discussion_r1155493898
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/OffHeapBitmapInvertedIndexCreator.java:
##########
@@ -83,13 +86,26 @@ public final class OffHeapBitmapInvertedIndexCreator
implements DictionaryBasedI
public OffHeapBitmapInvertedIndexCreator(File indexDir, FieldSpec fieldSpec,
int cardinality, int numDocs,
int numValues)
throws IOException {
- String columnName = fieldSpec.getName();
- _invertedIndexFile = new File(indexDir, columnName +
V1Constants.Indexes.BITMAP_INVERTED_INDEX_FILE_EXTENSION);
- _forwardIndexValueBufferFile = new File(indexDir, columnName +
FORWARD_INDEX_VALUE_BUFFER_SUFFIX);
- _forwardIndexLengthBufferFile = new File(indexDir, columnName +
FORWARD_INDEX_LENGTH_BUFFER_SUFFIX);
- _invertedIndexValueBufferFile = new File(indexDir, columnName +
INVERTED_INDEX_VALUE_BUFFER_SUFFIX);
- _invertedIndexLengthBufferFile = new File(indexDir, columnName +
INVERTED_INDEX_LENGTH_BUFFER_SUFFIX);
- _singleValue = fieldSpec.isSingleValueField();
+ this(indexDir, fieldSpec, cardinality, numDocs, numValues,
+ V1Constants.Indexes.BITMAP_INVERTED_INDEX_FILE_EXTENSION);
+ }
+
+ public OffHeapBitmapInvertedIndexCreator(File indexDir, FieldSpec fieldSpec,
int cardinality, int numDocs,
+ int numValues, String extension)
+ throws IOException {
+ this(indexDir, fieldSpec.getName(), fieldSpec.isSingleValueField(),
cardinality, numDocs, numValues, extension);
+ }
+
+ public OffHeapBitmapInvertedIndexCreator(File indexDir, String columnName,
boolean singleValue, int cardinality,
+ int numDocs, int numValues, String extension)
+ throws IOException {
+ String ext =
extension.equals(V1Constants.Indexes.BITMAP_INVERTED_INDEX_FILE_EXTENSION) ? ""
: "." + extension;
Review Comment:
Would this is simpler if ext was Optional<String>, and
`_invertedIndexFile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
