xiangfu0 commented on code in PR #10468:
URL: https://github.com/apache/pinot/pull/10468#discussion_r1152726183
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##########
@@ -650,22 +655,19 @@ public boolean equals(Object o) {
if (EqualityUtils.isSameReference(this, o)) {
return true;
}
-
if (EqualityUtils.isNullOrNotSameClass(this, o)) {
return false;
}
-
Schema that = (Schema) o;
-
- return EqualityUtils.isEqual(_schemaName, that._schemaName) &&
EqualityUtils
- .isEqualIgnoreOrder(_dimensionFieldSpecs, that._dimensionFieldSpecs)
&& EqualityUtils
- .isEqualIgnoreOrder(_metricFieldSpecs, that._metricFieldSpecs) &&
EqualityUtils
- .isEqual(_timeFieldSpec, that._timeFieldSpec) && EqualityUtils
- .isEqualIgnoreOrder(_dateTimeFieldSpecs, that._dateTimeFieldSpecs) &&
EqualityUtils
- .isEqualIgnoreOrder(_complexFieldSpecs, that._complexFieldSpecs) &&
EqualityUtils
- .isEqualMap(_fieldSpecMap, that._fieldSpecMap) && EqualityUtils
- .isEqual(_primaryKeyColumns, that._primaryKeyColumns) && EqualityUtils
- .isEqual(_hasJSONColumn, that._hasJSONColumn);
+ //@formatter:off
+ return EqualityUtils.isEqual(_schemaName, that._schemaName)
Review Comment:
why removed _fieldSpecMap and _hasJSONColumn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
