KKcorps opened a new pull request, #10502: URL: https://github.com/apache/pinot/pull/10502
Currently we use `_reuse` object in the `MemoryOptimizedDimensionTable` class to update the results. This however is not thread safe when `.get` function is called from multiple threads. There are three possible solutions to this - 1. Use synchronized on the .get method which makes it slow 2. Create a new `GenericRow` object for every `.get` call which leads to higher memory usage 3. Pass the `GenericRow` object created in the `LookupTransfrom` function. The transform function should create one object per execution ensuring they are not shared. I have gone with the 3rd approach here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
