gortiz opened a new pull request, #10491: URL: https://github.com/apache/pinot/pull/10491
This PR include a couple of small changes that were included in #10184 but can be merged alone in order to merge it earlier and simplify the other PR. First, this PR adds a runtime dependency to testng in `pinot-compability-verifier`. That dependency was used but not declared. I discovered this when one of the test failed, which throws a testng assertion error. The funny thing is that the assertion error class wasn't in the classpath, so the error I'd got was a class not found exception. Once I added this dependency, the error message I had was the actual error that I had to solve. It also adds a a new method `TestUtils.waitForCondition` that accepts a `SupplierWithException`. If the supplier throws, then the error is caught and retried until. This will repeated until the supplier doesn't fail or there is a timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
