snleee commented on code in PR #10484:
URL: https://github.com/apache/pinot/pull/10484#discussion_r1149670583
##########
pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java:
##########
@@ -64,7 +64,13 @@
public class TableConfigSerDeTest {
-
+ @Test
+ public void testTableConfigBuilderMetricsColumnOptimizationOptions() {
+ TableConfig tableConfig = new
TableConfigBuilder(TableType.OFFLINE).setTableName("testTable").
+
setOptimizeDictionaryForMetrics(true).setNoDictionarySizeRatioThreshold(0.72).build();
+
assertEquals(tableConfig.getIndexingConfig().getNoDictionarySizeRatioThreshold(),
0.72);
+
assertEquals(tableConfig.getIndexingConfig().isOptimizeDictionaryForMetrics(),
true);
Review Comment:
can we add the ser/de test as well?
From other test:
```
// Serialize then de-serialize
TableConfig tableConfigToCompare =
JsonUtils.stringToObject(tableConfig.toJsonString(), TableConfig.class);
assertEquals(tableConfigToCompare, tableConfig);
checkQuotaConfig(tableConfigToCompare);
tableConfigToCompare =
TableConfigUtils.fromZNRecord(TableConfigUtils.toZNRecord(tableConfig));
assertEquals(tableConfigToCompare, tableConfig);
checkQuotaConfig(tableConfigToCompare);
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
