gortiz commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1149366291
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/geospatial/BaseH3IndexCreator.java:
##########
@@ -101,6 +102,11 @@ public abstract class BaseH3IndexCreator implements
GeoSpatialIndexCreator {
_lowestResolution = resolution.getLowestResolution();
}
+ @Override
+ public Geometry deserialize(byte[] bytes) {
Review Comment:
This is another case where I decided to do not touch the code we already
have. There are several usages of each constant in V1Constants around the code.
We can refactor them to use the value returned by each
`IndexType.getFileExtension` but it would require to provide the
`ColumnMetadata` (at least if we use the general method).
As said, I preferred to do not modify the code we already have if there is
no need to do that in order to reduce the number of changes. I would vote to
apply the change, but in new PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
