gortiz commented on code in PR #10193:
URL: https://github.com/apache/pinot/pull/10193#discussion_r1147229306
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/StandardIndexes.java:
##########
@@ -39,21 +39,64 @@
* included in a Pinot distribution. {@link StandardIndexes} contains one
get method for each standard index,
* providing a typesafe way to get these references. Instead of having to
write something like
* {@code (IndexType<BloomFilterConfig, BloomFilterReader, IndexCreator>)
- * IndexService.getInstance().getOrThrow("bloom_filter")},
+ * IndexService.getInstance().get("bloom_filter")},
* a caller can simply use {@link StandardIndexes#bloomFilter()}
* </p>
*/
@SuppressWarnings("unchecked")
public class StandardIndexes {
+ public static final String FORWARD_ID = "forward_index";
Review Comment:
It was important because there were some code that iterate over the
constants in a very specific order. In these cases I kept the order by
explicitly introduce an order in the iteration, which is more verbose, but IMHO
better as it explicitly introduce the order where the order really matters
instead of implicitly use an order defined somewhere else.
But as you said, I had to deal with that in #10184. This is one of the
reasons that PR is going to be trickier to merge than this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
