aidar-st opened a new pull request, #10469:
URL: https://github.com/apache/pinot/pull/10469
### Problem
We are seeing errors in logs while launching pinot:
```
[2023-03-07 13:36:31.903103]
/pay/deploy/pinot-sandbox/current/bin/pinot-admin.sh: 119: [[: not found
[2023-03-07 13:36:31.903133]
/pay/deploy/pinot-sandbox/current/bin/pinot-admin.sh: 131: [[: not found
[2023-03-07 13:36:31.912766]
/pay/deploy/pinot-sandbox/current/bin/pinot-admin.sh: 131: [[: not found
```
### Solution
Sh doesn't support `[[` construct, so change launcher to use bash
explicitly. Error comes from this section:
```
if [ -n "$PLUGINS_INCLUDE" ] ; then
if [[ "$PLUGINS_INCLUDE" = *,* ]]
then
echo "\$PLUGINS_INCLUDE should use ; as the delimiter"
exit 1
fi
```
Leaving `#!/bin/sh` works on some systems that have set default shell to be
bash, but most of the Debian based distributives use dash as default, since it
is lighter to run.
### Testing
- Bash is fully sh compatible
- Run `./pinot-tools-pkg/bin/pinot-admin.sh` on ubuntu verify
- Run `./pinot-tools-pkg/bin/quick-start-batch.sh` on mac to verify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
