saurabhd336 commented on code in PR #10184:
URL: https://github.com/apache/pinot/pull/10184#discussion_r1136745961
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java:
##########
@@ -162,22 +165,27 @@ private File getValidDocIdsSnapshotFile() {
}
@Override
- public Dictionary getDictionary(String column) {
+ public <I extends IndexReader> I getIndex(String column, IndexType<?, I, ?>
type) {
ColumnIndexContainer container = _indexContainerMap.get(column);
if (container == null) {
throw new NullPointerException("Invalid column: " + column);
}
- return container.getDictionary();
+ return type.getIndexReader(container);
+ }
+
+ @Override
+ public Dictionary getDictionary(String column) {
Review Comment:
Do we need these specific methods now that we have a generic `<I extends
IndexReader> I getIndex(String column, IndexType<?, I, ?> type)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
