Jackie-Jiang commented on code in PR #10419:
URL: https://github.com/apache/pinot/pull/10419#discussion_r1136293538
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -250,7 +250,24 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable SqlNodeAndOption
}
String query = sql.asText();
requestContext.setQuery(query);
- return handleRequest(requestId, query, sqlNodeAndOptions, request,
requesterIdentity, requestContext);
+ BrokerResponse brokerResponse = handleRequest(requestId, query,
sqlNodeAndOptions, request,
+ requesterIdentity, requestContext);
+
+ boolean dropResults = false;
+ if (request.has(Broker.Request.QUERY_OPTIONS)) {
+ String queryOptions = request.get(Broker.Request.QUERY_OPTIONS).asText();
+ Map<String, String> optionsFromString =
RequestUtils.getOptionsFromString(queryOptions);
+ if
(optionsFromString.getOrDefault(Broker.Request.QueryOptionKey.DROP_RESULTS,
"false")
Review Comment:
It is equivalent to
`Boolean.parseBoolean(queryOptions.get(QueryOptionKey.DROP_RESULTS))`
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -250,7 +250,24 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable SqlNodeAndOption
}
String query = sql.asText();
requestContext.setQuery(query);
- return handleRequest(requestId, query, sqlNodeAndOptions, request,
requesterIdentity, requestContext);
+ BrokerResponse brokerResponse = handleRequest(requestId, query,
sqlNodeAndOptions, request,
+ requesterIdentity, requestContext);
+
+ boolean dropResults = false;
+ if (request.has(Broker.Request.QUERY_OPTIONS)) {
+ String queryOptions = request.get(Broker.Request.QUERY_OPTIONS).asText();
+ Map<String, String> optionsFromString =
RequestUtils.getOptionsFromString(queryOptions);
+ if
(optionsFromString.getOrDefault(Broker.Request.QueryOptionKey.DROP_RESULTS,
"false")
Review Comment:
You may put this logic into `QueryOptionsUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
