walterddr commented on code in PR #10405:
URL: https://github.com/apache/pinot/pull/10405#discussion_r1134721850
##########
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/BaseBinaryGeoTransformFunction.java:
##########
@@ -46,17 +46,15 @@ public abstract class BaseBinaryGeoTransformFunction
extends BaseTransformFuncti
private double[] _doubleResults;
@Override
- public void init(List<TransformFunction> arguments, Map<String, DataSource>
dataSourceMap) {
- Preconditions
- .checkArgument(arguments.size() == 2, "2 arguments are required for
transform function: %s", getName());
+ public void init(List<TransformFunction> arguments, Map<String,
ColumnContext> columnContextMap) {
Review Comment:
probably include `ColumnContext` in the PR description for the
refactor/rename
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/BaseProjectOperator.java:
##########
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator;
+
+import java.util.Map;
+import org.apache.pinot.common.request.context.ExpressionContext;
+import org.apache.pinot.core.operator.blocks.ValueBlock;
+
+
+public abstract class BaseProjectOperator<T extends ValueBlock> extends
BaseOperator<T> {
Review Comment:
do we need the generic here? seems like the usages are always ValueBlock
instead of the generic extension of `T` right? any chance we want to use it
differently going forward?
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationOperator.java:
##########
@@ -63,25 +62,25 @@ protected AggregationResultsBlock getNextBlock() {
} else {
aggregationExecutor = new
DefaultAggregationExecutor(_aggregationFunctions);
}
- TransformBlock transformBlock;
- while ((transformBlock = _transformOperator.nextBlock()) != null) {
- _numDocsScanned += transformBlock.getNumDocs();
- aggregationExecutor.aggregate(transformBlock);
+ ValueBlock valueBlock;
+ while ((valueBlock = _projectOperator.nextBlock()) != null) {
+ _numDocsScanned += valueBlock.getNumDocs();
+ aggregationExecutor.aggregate(valueBlock);
}
// Build intermediate result block based on aggregation result from the
executor
return new AggregationResultsBlock(_aggregationFunctions,
aggregationExecutor.getResult());
}
@Override
- public List<Operator> getChildOperators() {
- return Collections.singletonList(_transformOperator);
+ public List<BaseProjectOperator<?>> getChildOperators() {
Review Comment:
This API needs not to be change right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
