richardstartin commented on PR #10404: URL: https://github.com/apache/pinot/pull/10404#issuecomment-1462932810
On second thoughts, this seems like an objectively bad idea wrt the rest of the query engine. If some other index filters down to 100 rows, scanning a 100k+ cardinality dictionary is wasted work. If no other index can provide that filtering, and a query with a regex needs to be fast, the table config is suboptimal and the user should apply an FST index instead of Pinot optimising this predicate evaluator for full scans. However, if there were a filter context to indicate how selective the rest of the query is, this could be a good idea to improve the worst case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
