Jackie-Jiang commented on code in PR #10357:
URL: https://github.com/apache/pinot/pull/10357#discussion_r1131492493
##########
pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorService.java:
##########
@@ -78,6 +77,8 @@ public SelectionOperatorService(QueryContext queryContext,
DataSchema dataSchema
_offset = queryContext.getOffset();
_numRowsToKeep = _offset + queryContext.getLimit();
assert queryContext.getOrderByExpressions() != null;
+ // TODO: Do not use type compatible comparator for performance since we
don't support different data schema on
Review Comment:
Good point. Added it in the `TODO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
