jugomezv commented on code in PR #10387:
URL: https://github.com/apache/pinot/pull/10387#discussion_r1128416849
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -305,9 +326,12 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
long endTimeMs = preSelectedSegment.getEndTimeMs();
if (endTimeMs >= bucketStartMs) {
// For segments overlapping with current bucket, add to the
result list
- if (!isMergedSegment(preSelectedSegment, mergeLevel)) {
+ if (!isMergedSegment(preSelectedSegment, mergeLevel,
sortedMergeLevels)) {
Review Comment:
Should we compute sorted mergelevels closer to this statement as there is
lots of code before? and no earlier use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
