Jackie-Jiang commented on PR #10359: URL: https://github.com/apache/pinot/pull/10359#issuecomment-1454343303
It is great to list 3 different convergences. We might want to track different stats for each of them though. When tracking the convergence, we want to track both the segments not converged, and how many replicas are different (we may track total number of replicas that are different from the 2 views). For the `targetToIdealStateConvergence`, we should call it `currentToTargetConvergence`, and the target should be the re-computed one instead of the initial calculated one in case the IS changed while rebalancing is running. For the `timeElapsed` info, let's use seconds and round it to whole number which is much easier to read -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
