siddharthteotia commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1122648627
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageMetadata.java:
##########
@@ -81,6 +82,12 @@ public void attach(StageNode stageNode) {
_requiresSingletonInstance = _requiresSingletonInstance ||
(sortNode.getCollationKeys().size() > 0
&& sortNode.getOffset() != -1);
}
+ if (stageNode instanceof WindowNode) {
+ WindowNode windowNode = (WindowNode) stageNode;
+ // Empty OVER() and OVER(ORDER BY) need to be processed on a singleton
node. OVER() with PARTITION BY can be
Review Comment:
> Empty OVER() and OVER(ORDER BY) need to be processed on a singleton node.
Add a TODO to improve this in future per original discussion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
