Jackie-Jiang commented on code in PR #10350:
URL: https://github.com/apache/pinot/pull/10350#discussion_r1122440824
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java:
##########
@@ -51,7 +51,8 @@ public BalancedInstanceSelector(String tableNameWithType,
BrokerMetrics brokerMe
@Override
Map<String, String> select(List<String> segments, int requestId,
- Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions) {
+ Map<String, List<String>> segmentToEnabledInstancesMap, Map<String,
String> queryOptions,
+ long nowMillis) {
Review Comment:
We want the query time operation to be very light weight. Basically we
should process old/new segments and put them into cache before query time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
