KKcorps commented on code in PR #10337:
URL: https://github.com/apache/pinot/pull/10337#discussion_r1119614693
##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java:
##########
@@ -102,16 +102,14 @@ enum MetadataValueType {
*/
enum MetadataKey {
UNKNOWN(0, "unknown", MetadataValueType.STRING),
- TABLE(1, "table", MetadataValueType.STRING), // NOTE: this key is only
used in PrioritySchedulerTest
+ TABLE(1, "table", MetadataValueType.STRING),
Review Comment:
This is dependent on `ExecutionStatsAggregator` not being dependent on field
names, plus InstanceResponseBlock also not returning the field names. Both of
these need to be changed first, for this to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
