snleee commented on code in PR #10317:
URL: https://github.com/apache/pinot/pull/10317#discussion_r1115242159


##########
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java:
##########
@@ -630,8 +630,10 @@ private boolean copyInputStreamToDst(InputStream 
inputStream, URI dstUri, byte[]
     int bytesRead;
     long totalBytesRead = 0;
     byte[] buffer = new byte[BUFFER_SIZE];
+    // TODO: the newer client now has the API 'uploadFromFile' that directly 
takes the file as an input. We can replace

Review Comment:
   we don't need to bump up the dependency for this. This just needs a bit 
larger surgery of the adls gen 2 client (rewriting the copyFromLocal / 
copyToLocal). I will probably file another pr for doing that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to