jadami10 commented on PR #10226: URL: https://github.com/apache/pinot/pull/10226#issuecomment-1441151468
> I see the reason why the data is not sorted after filtering is that we are filtering on initialData, whereas filtered data is stored in finalData. this was an intentional design choice to separate initial and final data so it's easier to filter/unfilter, sort/unsort. I'm hoping we can merge this as is to at least fix the biggest break where filtering and sorting together don't work at all. It's going to take me quite a while to understand how the `useEffect` and `useCallback` all work together, so I don't think i'll be able to add further to this. And maybe long term it's not even worth investing in our own table class. Material UI has a table that is effectively the same, https://mui.com/material-ui/react-table/#data-table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
