siddharthteotia commented on code in PR #10248:
URL: https://github.com/apache/pinot/pull/10248#discussion_r1114015034
##########
pinot-query-planner/src/test/resources/queries/GroupByPlans.json:
##########
@@ -91,6 +91,92 @@
"\n LogicalTableScan(table=[[a]])",
"\n"
]
+ },
+ {
+ "description": "SQL hint based group by optimization with select and
aggregate column",
Review Comment:
I don't think this hint is applicable to the 2nd type of queries unless I am
missing something or at least in the original request, I couldn't think of a
scenario where this will apply to pure aggregation only queries.
+1 on ignoring the hint for aggregation only queries if we all agree with
the above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
