Jackie-Jiang commented on code in PR #10284:
URL: https://github.com/apache/pinot/pull/10284#discussion_r1107829134
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3434,23 +3444,20 @@ public void endReplaceSegments(String
tableNameWithType, String segmentLineageEn
// Check that all the segments from 'segmentsTo' exist in the table
Set<String> segmentsForTable = new
HashSet<>(getSegmentsFor(tableNameWithType, false));
-
Preconditions.checkArgument(segmentsForTable.containsAll(lineageEntry.getSegmentsTo()),
String.format(
- "Not all segments from 'segmentsTo' are available in the table.
(tableName = '%s', segmentsTo = '%s', "
- + "segmentsFromTable = '%s')", tableNameWithType,
lineageEntry.getSegmentsTo(), segmentsForTable));
+ List<String> segmentsTo = lineageEntry.getSegmentsTo();
Review Comment:
Good call, updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
