richardstartin commented on code in PR #10254:
URL: https://github.com/apache/pinot/pull/10254#discussion_r1101850816
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateUtils.java:
##########
@@ -139,10 +143,40 @@ public static IntSet getDictIdSet(BaseInPredicate
inPredicate, Dictionary dictio
}
break;
case STRING:
- for (String value : values) {
- int dictId = dictionary.indexOf(value);
- if (dictId >= 0) {
- dictIdSet.add(dictId);
+ if (values.size() >
RequestContextUtils.THRESHOLD_OF_LARGE_IN_CLAUSE_VALUES) {
+ if (bloomFilter != null) {
+ for (String value : values) {
+ if (bloomFilter.mightContain(value)) {
+ int dictId = dictionary.indexOf(value);
+ if (dictId >= 0) {
+ dictIdSet.add(dictId);
+ }
+ }
+ }
+ } else {
+ int valueIdx = 0;
+ int dictIdx = 0;
+ while (valueIdx < values.size() && dictIdx < dictionary.length()) {
+ String value = values.get(valueIdx);
+ String dictValue = dictionary.getStringValue(dictIdx);
+ int compareResult = value.compareTo(dictValue);
Review Comment:
Is there a way to make use of the UTF-8 comparison pushdown used in binary
searches? It's defined on `ValueReader` - maybe it could be exposed on
`Dictionary`? Or `Dictionary` could provide methods to fill a set of dictionary
ids given a list of a strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
