Jackie-Jiang commented on code in PR #10216:
URL: https://github.com/apache/pinot/pull/10216#discussion_r1097843619
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -111,6 +112,10 @@ public synchronized void init(PinotConfiguration config,
HelixManager helixManag
_instanceId = _instanceDataManagerConfig.getInstanceId();
_helixManager = helixManager;
_serverMetrics = serverMetrics;
+ if (StringUtils.isEmpty(_instanceDataManagerConfig.getSegmentStoreUri())) {
Review Comment:
Suggest not adding this check because this is not mandatory config
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/TableDataManagerProvider.java:
##########
@@ -72,6 +77,15 @@ public static TableDataManager
getTableDataManager(TableDataManagerConfig tableD
}
break;
case REALTIME:
+ Map<String, String> streamConfigMap =
IngestionConfigUtils.getStreamConfigMap(
+ tableDataManagerConfig.getTableConfig());
+ if
(Boolean.parseBoolean(streamConfigMap.getOrDefault(StreamConfigProperties.SERVER_UPLOAD_TO_DEEPSTORE,
+ "false"))
Review Comment:
(nit)
```suggestion
if
(Boolean.parseBoolean(streamConfigMap.get(StreamConfigProperties.SERVER_UPLOAD_TO_DEEPSTORE))
```
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentCommitterFactory.java:
##########
@@ -69,9 +70,13 @@ public SegmentCommitter createSegmentCommitter(boolean
isSplitCommit, SegmentCom
boolean uploadToFs = _streamConfig.isServerUploadToDeepStore();
String peerSegmentDownloadScheme =
_tableConfig.getValidationConfig().getPeerSegmentDownloadScheme();
- // TODO: exists for backwards compatibility. remove peerDownloadScheme
non-null check once users have migrated
- if (uploadToFs || peerSegmentDownloadScheme != null) {
- segmentUploader = new
PinotFSSegmentUploader(_indexLoadingConfig.getSegmentStoreURI(),
+ String segmentStoreUri = _indexLoadingConfig.getSegmentStoreURI();
+
+ // We seem to allow the server instance to come up without a valid segment
store uri. Hence, this check is needed.
+
+ if (peerSegmentDownloadScheme != null ||
(!StringUtils.isEmpty(segmentStoreUri) && uploadToFs)) {
Review Comment:
We don't need this extra check because we already checked at table creation
time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
