walterddr commented on code in PR #10190:
URL: https://github.com/apache/pinot/pull/10190#discussion_r1094865213
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/exchange/BlockExchange.java:
##########
@@ -38,23 +39,25 @@ public abstract class BlockExchange {
// TODO: Deduct this value via grpc config maximum byte size; and make it
configurable with override.
// TODO: Max block size is a soft limit. only counts fixedSize datatable
byte buffer
private static final int MAX_MAILBOX_CONTENT_SIZE_BYTES = 4 * 1024 * 1024;
-
- private final MailboxService<TransferableBlock> _mailbox;
- private final List<MailboxIdentifier> _destinations;
+ private final List<SendingMailbox> _sendingMailboxes;
Review Comment:
for this and the rest of the generic raw reference. please fix them with
```suggestion
private final List<SendingMailbox<TransferableBlock>> _sendingMailboxes;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
