This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 76a38bffab unignore tests that pass now (#10215)
76a38bffab is described below
commit 76a38bffab2530ca427e1ee281d50056a6b90633
Author: Rong Rong <ro...@apache.org>
AuthorDate: Wed Feb 1 12:50:04 2023 -0800
unignore tests that pass now (#10215)
Co-authored-by: Rong Rong <ro...@startree.ai>
---
.../src/test/resources/queries/Aggregates.json | 9 ++-------
.../src/test/resources/queries/MathFuncs.json | 16 ----------------
.../src/test/resources/queries/SelectExpressions.json | 6 +-----
.../src/test/resources/queries/TypeCasting.json | 8 ++------
4 files changed, 5 insertions(+), 34 deletions(-)
diff --git a/pinot-query-runtime/src/test/resources/queries/Aggregates.json
b/pinot-query-runtime/src/test/resources/queries/Aggregates.json
index 7e2f7e4e9c..e4243d2fc0 100644
--- a/pinot-query-runtime/src/test/resources/queries/Aggregates.json
+++ b/pinot-query-runtime/src/test/resources/queries/Aggregates.json
@@ -21,9 +21,7 @@
},
"queries": [
{
- "ignored": true,
"psql": "4.2.7",
- "comments": "result error:average doesn't work because we round up but
h2 round down for integer",
"description": "average int",
"sql": "SELECT avg(int_col) FROM {tbl}"
},
@@ -173,16 +171,13 @@
},
{
"psql": "4.2.7",
- "ignored": true,
"description": "aggregate int column and filter by int column",
- "comments": "rounding error",
- "sql": "SELECT sum(1 /int_col) FROM {tbl} WHERE int_col > 0"
+ "sql": "SELECT sum(1 / int_col) FROM {tbl} WHERE int_col > 0"
},
{
"psql": "4.2.7",
"description": "aggregate double column and filter by double column",
- "comments": "rounding error",
- "sql": "SELECT sum(1 /double_col) FROM {tbl} WHERE double_col < 1"
+ "sql": "SELECT sum(1 / double_col) FROM {tbl} WHERE double_col < 1"
},
{
"psql": "4.2.7",
diff --git a/pinot-query-runtime/src/test/resources/queries/MathFuncs.json
b/pinot-query-runtime/src/test/resources/queries/MathFuncs.json
index 2a84c4b1d7..6e586f2dc2 100644
--- a/pinot-query-runtime/src/test/resources/queries/MathFuncs.json
+++ b/pinot-query-runtime/src/test/resources/queries/MathFuncs.json
@@ -200,14 +200,10 @@
},
"queries": [
{
- "ignored": true,
- "comment": "should round on the integer but we return a floating
point",
"description": "test divide on integer columns",
"sql": "SELECT intCol / longCol FROM {numTbl}"
},
{
- "ignored": true,
- "comment": "should round on the integer but we return a floating
point",
"description": "test divide on int literal with columns",
"sql": "SELECT intCol / 10 FROM {numTbl}"
},
@@ -216,8 +212,6 @@
"sql": "SELECT intCol / 1.2 FROM {numTbl}"
},
{
- "ignored": true,
- "comment": "should round on the integer but we return a floating
point",
"description": "test divide on literals",
"sql": "SELECT 3 / 5 FROM {numTbl}"
},
@@ -244,9 +238,7 @@
"sql": "SELECT intCol / doubleCol FROM {numTbl}"
},
{
- "ignored": true,
"description": "test divide on overflow",
- "comment": "somehow there is value diff",
"sql": "SELECT floatCol / 1e-15 FROM {numTbl}"
}
]
@@ -270,8 +262,6 @@
},
"queries": [
{
- "ignored": true,
- "comment": "we are returning -0.0 for some reason",
"description": "test mod on integer columns",
"sql": "SELECT intCol % longCol FROM {numTbl}"
},
@@ -469,8 +459,6 @@
"sql": "SELECT doubleCol + 1e250 FROM {numTbl}"
},
{
- "ignored": true,
- "comments": "Pinot hoist type to double but H2 doesn't",
"description": "test addition on floatCol plus large decimal to
convert to double",
"sql": "SELECT floatCol + 1e50 FROM {numTbl}"
},
@@ -487,8 +475,6 @@
"sql": "SELECT doubleCol - 1e250 FROM {numTbl}"
},
{
- "ignored": true,
- "comments": "Pinot hoist type to double but H2 doesn't",
"description": "test on floatCol plus large decimal to convert to
double",
"sql": "SELECT floatCol - 1e50 FROM {numTbl}"
},
@@ -505,8 +491,6 @@
"sql": "SELECT doubleCol * 1e50 FROM {numTbl}"
},
{
- "ignored": true,
- "comments": "Pinot hoist type to double but H2 doesn't",
"description": "test on floatCol plus large decimal to convert to
double",
"sql": "SELECT floatCol * 1e50 FROM {numTbl}"
},
diff --git
a/pinot-query-runtime/src/test/resources/queries/SelectExpressions.json
b/pinot-query-runtime/src/test/resources/queries/SelectExpressions.json
index 24fb9ab2c7..211b0cd56b 100644
--- a/pinot-query-runtime/src/test/resources/queries/SelectExpressions.json
+++ b/pinot-query-runtime/src/test/resources/queries/SelectExpressions.json
@@ -53,11 +53,7 @@
{ "sql": "SELECT intCol, intCol, doubleCol, strCol, strCol FROM {tbl1}"
},
{ "sql": "SELECT {tbl1}.intCol, {tbl1}.intCol, {tbl1}.doubleCol,
{tbl2}.strCol, {tbl2}.strCol FROM {tbl1}, {tbl2} WHERE {tbl1}.intCol =
{tbl2}.intCol" },
{ "sql": "SELECT {tbl2}.intCol, {tbl2}.intCol FROM {tbl1}, {tbl2} WHERE
{tbl1}.intCol = {tbl2}.intCol AND {tbl1}.intCol < 100 ORDER BY
{tbl1}.doubleCol" },
- {
- "ignored": true,
- "comment": "select intCol, intCol without aliasing one of them is not
supported.",
- "sql": "SELECT intCol, intCol FROM {tbl1} WHERE intCol < 100"
- }
+ { "sql": "SELECT intCol, intCol FROM {tbl1} WHERE intCol < 100"}
]
}
}
diff --git a/pinot-query-runtime/src/test/resources/queries/TypeCasting.json
b/pinot-query-runtime/src/test/resources/queries/TypeCasting.json
index f134cfd4b2..9510bf91ba 100644
--- a/pinot-query-runtime/src/test/resources/queries/TypeCasting.json
+++ b/pinot-query-runtime/src/test/resources/queries/TypeCasting.json
@@ -35,15 +35,11 @@
},
{ "sql": "SELECT CAST(floatCol AS DOUBLE) * 1e100, CAST(intCol AS
BIGINT) * 2000000000, CAST(longCol AS DOUBLE) * 1e100, CAST(boolCol AS INT)
FROM {tbl}" },
{ "sql": "SELECT CAST(a.floatCol AS DOUBLE) * 1e100, CAST(a.intCol AS
BIGINT) * 2000000000, CAST(b.longCol AS FLOAT) * 1e20, CAST(a.boolCol AS INT)
FROM {tbl} AS a JOIN {tbl} AS b ON a.intCol = b.intCol WHERE a.boolCol = true"
},
- {
- "ignored": true,
- "comments": "primitive cast not work: cast as DECIMAL doesn't work",
- "sql": "SELECT CAST(doubleCol AS DECIMAL) FROM {tbl} WHERE
bigDecimalCol > 0 AND CAST(bytesCol AS VARCHAR) != '1000'"
- },
+ { "sql": "SELECT CAST(doubleCol AS DECIMAL) FROM {tbl} WHERE
bigDecimalCol > 0 AND CAST(bytesCol AS VARCHAR) != '1000'" },
{
"ignored": true,
"comments": "special cast not work: timestamp cast not supported,
varchar cast not supported",
- "sql": "SELECT CAST(b.timestampCol AS BIGINT), CAST(stringCol AS
VARBINARY) FROM {tbl}"
+ "sql": "SELECT CAST(timestampCol AS BIGINT), CAST(stringCol AS
VARBINARY) FROM {tbl}"
}
]
},
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
