walterddr commented on code in PR #10108:
URL: https://github.com/apache/pinot/pull/10108#discussion_r1092332084
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -53,7 +54,7 @@ public GrpcSendingMailbox(String mailboxId,
GrpcMailboxService mailboxService) {
public void init()
throws UnsupportedOperationException {
ManagedChannel channel = _mailboxService.getChannel(_mailboxId);
- PinotMailboxGrpc.PinotMailboxStub stub = PinotMailboxGrpc.newStub(channel);
+ PinotMailboxGrpc.PinotMailboxStub stub =
PinotMailboxGrpc.newStub(channel).withDeadlineAfter(2, TimeUnit.MINUTES);
Review Comment:
+1 let's use the query deadline here as it is a a GRPC stub deadline not a
mailbox concept deadline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
