gortiz opened a new pull request, #10194: URL: https://github.com/apache/pinot/pull/10194
This is a partial draft PR related to https://github.com/apache/pinot/issues/10183. The whole PR is in https://github.com/apache/pinot/pull/10184. It isn't intended to be merged as it is and it doesn't require to compile or pass the checks. It has been created in order to make it easier to understand the PR with all the changes. This PR depends on https://github.com/apache/pinot/pull/10193. Readers only interested in the difference between this and the previous PR can focus on https://github.com/gortiz/pinot/pull/3 In this PR, `ColumnIndexType` has been deleted and its usages replaces by using either `StandardIndexes` or `IndexService`. Like previous PRs, this almost doesn't contain important code changes. The most significant change is on how the file extension used by V1 and V2 segments is calculated. It was previously implemented with a `switch`. Obviously we cannot use a switch with classes in Java, so usually we would need to change it with a bunch of if-then-else (like this PR does with IndexHandlerFactory) but if that was the case, given that the number of indexes is not defined at compile time we need another solution and the easiest way to do that is to move the responsibility of how to calculate the extension into the IndexType itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
