walterddr commented on code in PR #10170:
URL: https://github.com/apache/pinot/pull/10170#discussion_r1088445842
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##########
@@ -82,6 +82,10 @@ public List<MultiStageOperator> getChildOperators() {
return ImmutableList.of(_upstreamOperator);
}
+ @Override
+ public void cancel(Throwable e) {
+ }
Review Comment:
could you also add tests to cover the overwritten cancel and close methods?
for example this one seems like if we encountered a SORT at the top it will
not populate cancellation downwards?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
