jugomezv commented on code in PR #10182:
URL: https://github.com/apache/pinot/pull/10182#discussion_r1088276901
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -58,6 +57,9 @@
private final Class _clazz;
+ // The purpose of having _gaugeValues is to make gauge metric updatable.
Review Comment:
Is the comment in line 44 relevant anymore?
/**
* Common code for metrics implementations.
* TODO: 1. With gauge updatable, we can remove _gaugeValues 2. Remove
methods with callback in name since the callback
* function can not be updated.
*/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
