siddharthteotia commented on code in PR #10168: URL: https://github.com/apache/pinot/pull/10168#discussion_r1084749109
########## pinot-query-runtime/src/test/resources/queries/TableExpressions.json: ########## @@ -22,6 +25,10 @@ { "sql": "SELECT * FROM {tbl} WHERE intCol > 5" }, { "sql": "SELECT * FROM {tbl} WHERE strCol IN ('foo', 'bar')" }, { "sql": "SELECT * FROM {tbl} WHERE intCol IN (196883, 42)" }, + { "sql": "SELECT * FROM {tbl} WHERE strCol IN ('foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar', 'foo', 'bar')" }, Review Comment: Wondering that we added 3 new queries but didn't add corresponding expected result/response ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org