[GitHub] [pinot] jugomezv commented on a diff in pull request #10121: Add a tracker for end-to-end consumption delay of events.

[via GitHub]

jugomezv commented on code in PR #10121:
URL: https://github.com/apache/pinot/pull/10121#discussion_r1084482653


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -240,8 +240,8 @@ protected void doShutdown() {
    * @param ingestionTimeMs Ingestion delay being reported.
    * @param partitionGroupId Partition ID for which delay is being updated.
    */
-  public void updateIngestionDelay(long ingestionTimeMs, int partitionGroupId) 
{
-    _ingestionDelayTracker.updateIngestionDelay(ingestionTimeMs, 
partitionGroupId);
+  public void updateIngestionDelay(long ingestionTimeMs, long creationTimeMs, 
int partitionGroupId) {
+    _ingestionDelayTracker.updateIngestionDelay(ingestionTimeMs, 
creationTimeMs, partitionGroupId);

Review Comment:
   Addressed in last commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org