navina commented on code in PR #10121:
URL: https://github.com/apache/pinot/pull/10121#discussion_r1083136215


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamMessageMetadata.java:
##########
@@ -30,23 +30,29 @@
  */
 public class StreamMessageMetadata implements RowMetadata {
   private final long _recordIngestionTimeMs;
+  private final long _recordCreationTimeMs;

Review Comment:
   Please add some javadoc on :
   1. what this field implies?
   2. Since this is part of the stream spi, how is a new stream connector 
expected to set this field? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to