sajjad-moradi commented on issue #10137: URL: https://github.com/apache/pinot/issues/10137#issuecomment-1399029119
We have some tables that use number of rows as flush threshold, but vast majority of the them use auto-tuning and have defined desired segment size. I think we should still have support for num rows config for backward compatibility, but we should strive for using desired segment size which is: 1. consistent (remains the same) if we uplift or downsize the cluster 2. segment size is an important factor in different aspects like memory management servers, segment build duration in commit protocol, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
