Jackie-Jiang commented on PR #10151: URL: https://github.com/apache/pinot/pull/10151#issuecomment-1397787608
> Does `LoaderTest.testPadding` pass with this change? I'm all for simplification (assuming whatever the motivation for adding `LoaderTest.testPadding` was no longer matters) but this isn't going to move the needle much performance wise. This test is removed in #10087 where we removed the non-zero padding support. That test is added mainly for testing the behavior of legacy '%' padding, which is much more common than null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
