siddharthteotia commented on code in PR #10120:
URL: https://github.com/apache/pinot/pull/10120#discussion_r1080618239


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -65,6 +65,7 @@ public enum AggregationFunctionType {
   STDDEVSAMP("stdDevSamp"),
   SKEWNESS("skewness"),
   KURTOSIS("kurtosis"),
+  FOURTHMOMENT("fourthmoment"),

Review Comment:
   So `SELECT fourthMoment(..) FROM FOO` will throw exception informing the 
user that it is an illegal / invalid aggregation function ? 
   
   In that case, I am fine with leaving here and later on figuring out how to 
hide it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to